Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes attestation payload from attest-blob's output & no base64 encoding #2498

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Nov 30, 2022

Fixes #2497

  • fix!: This writes and prints the signature (DSSE envelope) output as the JSON, NOT base64-encoded. Previously, this would base64-encode the envelope
  • fix!: This removes printing the attestation JSON to the std output. This confuses piping the output, since now both the DSSE envelope and the attestation are printed.
  • fix!: verify-blob-attestation now expects a JSON DSSE envelope (NOT base64-encoded)

BREAKINGCHANGE

  • verify-blob-attestation expects the JSON DSSE envelope. Previously, this was expected to be base64-encoded.
  • attest-blob outputs only the JSON DSSE envelope. Previously, it also printed the intoto attestation payload and the DSSE envelope was additionally base64-encoded.

Signed-off-by: Asra Ali asraa@google.com

Summary

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2498 (8490832) into main (64e7719) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2498   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         139      139           
  Lines        8592     8592           
=======================================
  Hits         2579     2579           
  Misses       5655     5655           
  Partials      358      358           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cmd/cosign/cli/attest/attest_blob.go Show resolved Hide resolved
@asraa asraa merged commit 9736529 into sigstore:main Dec 1, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosign attest-blob prints both the base64 encoded DSSE envelope and the attestation to the output
4 participants