Fix up UI messages #2629
Merged
Fix up UI messages #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Newman <zjn@chainguard.dev>
dlorenc
previously approved these changes
Jan 15, 2023
cpanato
reviewed
Jan 16, 2023
cmd/cosign/cli/sign/sign.go
Outdated
| @@ -155,7 +152,7 @@ func SignCmd(ro *options.RootOptions, ko options.KeyOpts, signOpts options.SignO | |||
|
|
|||
| var staticPayload []byte | |||
| if signOpts.PayloadPath != "" { | |||
| ui.Info(ctx, "Using payload from:", signOpts.PayloadPath) | |||
| ui.Info(ctx, "Using payload from: %s", signOpts.PayloadPath) | |||
There was a problem hiding this comment.
Nit will be good to have this called InfoF to match similar pattern like PrintF SPrintF ...
Signed-off-by: Zachary Newman <zjn@chainguard.dev>
|
I wanted to add golanglint support via (It works when I run |
Codecov Report
@@ Coverage Diff @@
## main #2629 +/- ##
=======================================
Coverage 30.03% 30.04%
=======================================
Files 146 146
Lines 9283 9280 -3
=======================================
Hits 2788 2788
+ Misses 6065 6062 -3
Partials 430 430
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
priyawadhwa
approved these changes
Jan 24, 2023
uralsemih
pushed a commit
to uralsemih/cosign
that referenced
this pull request
Jan 29, 2023
* Fix up UI messages Signed-off-by: Zachary Newman <zjn@chainguard.dev> * Rename Warn/Info to Warnf/Infof Signed-off-by: Zachary Newman <zjn@chainguard.dev> Signed-off-by: Zachary Newman <zjn@chainguard.dev>
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
* Fix up UI messages Signed-off-by: Zachary Newman <zjn@chainguard.dev> * Rename Warn/Info to Warnf/Infof Signed-off-by: Zachary Newman <zjn@chainguard.dev> Signed-off-by: Zachary Newman <zjn@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zachary Newman zjn@chainguard.dev
Summary
Release Note
Documentation