Loosen verification predicate type + better error messages #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #2737 +/- ##
==========================================
- Coverage 29.62% 29.55% -0.08%
==========================================
Files 151 151
Lines 9641 9648 +7
==========================================
- Hits 2856 2851 -5
- Misses 6348 6358 +10
- Partials 437 439 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hectorj2f
approved these changes
Feb 23, 2023
mattmoor
approved these changes
Feb 23, 2023
|
cc @priyawadhwa @znewman01 for thoughts on v2 |
|
+1 to this, breaking verification for existing attestations is not ideal. This should go in 2.0 |
|
Okay. I just talked to @priyawadhwa ✅ . I'm merging this change as it seems everyone approved it. |
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
…2737) * test policy-controller only. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Better error messages. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> --------- Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Loosen the policy validation restrictions. With the move to strict RFC3986 and the fact that some of the existing attestations out there are still using the non conformant predicate types, allow validating them with non-conformant predicate types.
Also, to aid folks with the 'guess-the-existing-predicate-type' game :) if attestations are found, but they do not match the predicate type that is being looked for, print out the predicates that were found. Hope is that this will make the migration from non conformant predicate types little easier.
Release Note
Documentation