Add a warning to remember how to configure a custom Gitlab host #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs sigstore#2730 Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
paolomainardi
force-pushed
the
feature/2730_gitlab_host_warning
branch
from
07e4ae4
to
13bd977
Compare
paolomainardi
changed the title
Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
+ Coverage 28.99% 29.51% +0.52%
==========================================
Files 151 151
Lines 9655 9655
==========================================
+ Hits 2799 2850 +51
+ Misses 6436 6366 -70
- Partials 420 439 +19 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cpanato
reviewed
Mar 17, 2023
pkg/cosign/git/gitlab/gitlab.go
Outdated
| @@ -70,6 +71,7 @@ func (g *Gl) PutSecret(ctx context.Context, ref string, pf cosign.PassFunc) erro | |||
| EnvironmentScope: gitlab.String("*"), | |||
| }) | |||
| if err != nil { | |||
| ui.Infof(ctx, "WARNING: if you want to use a custom Gitlab host, set the \"GITLAB_HOST\" environment variable.") | |||
There was a problem hiding this comment.
maybe, we can say something like: "if you are using a self-hosted gitlab please set the GITLAB_HOST your server name"
thanks for this PR!
There was a problem hiding this comment.
thanks for suggestion, changed!
Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
hectorj2f
reviewed
Mar 17, 2023
Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
hectorj2f
previously approved these changes
Mar 17, 2023
znewman01
previously approved these changes
Mar 17, 2023
cpanato
reviewed
Mar 17, 2023
pkg/cosign/git/gitlab/gitlab.go
Outdated
| @@ -70,6 +71,7 @@ func (g *Gl) PutSecret(ctx context.Context, ref string, pf cosign.PassFunc) erro | |||
| EnvironmentScope: gitlab.String("*"), | |||
| }) | |||
| if err != nil { | |||
| ui.Warnf(ctx, "if you are using a self-hosted gitlab please set the \"GITLAB_HOST\" your server name.") | |||
There was a problem hiding this comment.
nit: if in capital letter "If you are using a self-hosted ...
Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
…tore#2816) * feat: add warning for gitlab host refs sigstore#2730 Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com> * Use ui lib where applicable Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com> * fix: change the message of the warning when the host is not gitlab.com Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com> * fix: use ui.Warnf instead of ui.Infof Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com> * fix: use a capitalized warning message Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com> --------- Signed-off-by: Paolo Mainardi <paolomainardi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2730
Summary
Add a warning to explain how to use a custom Gitlab host.
I've also changed
fmt.Fprintlnwithui.Infofwhere applicable.Release Note
NONE
Documentation
NO