Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove COSIGN_EXPERIMENTAL setting for keyless in CI #2932

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Apr 26, 2023

Summary

PR removes the COSIGN_EXPERIMENTAL setting for the keyless verification since it is no longer required (since #2387).

Release Note

NONE

Documentation

no changes (though someone needs to go through the COSIGN_EXPERIMENTAL search hits in https://github.com/sigstore/docs and remove those that are no longer needed)

Signed-off-by: Dmitry S <dsavints@gmail.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2932 (4131a41) into main (3534a7d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2932   +/-   ##
=======================================
  Coverage   30.32%   30.32%           
=======================================
  Files         151      151           
  Lines        9451     9451           
=======================================
  Hits         2866     2866           
  Misses       6140     6140           
  Partials      445      445           

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato enabled auto-merge (squash) April 26, 2023 14:24
@cpanato cpanato merged commit 45c8c06 into sigstore:main Apr 26, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Apr 26, 2023
@dmitris dmitris deleted the ci-no-experimental-flag branch April 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants