Make predicate a required flag in attest commands #3033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default value for the
predicate
parameter for theattest
andattest-blob
commands is an empty string. However, an empty string is not a valid default value for this parameter resulting in an error.In #2937, it was suggested that the default value for this parameter should be
-
(read from stdin). But this results in somewhat odd behavior when stdin is not used.This commit retains the default value of
""
, but adds the following guardrails:--predicate
parameter required.I also ported the new behavior to the
attest-blob
command.Release Note
attest-blob
can now read predicate payload from standard input.Documentation
Updated the CLI docs accordingly.