Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for the workers become available again to continue the execution #3084

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 26, 2023

Summary

  • wait for the workers become available again to continue the execution

if you run in the container we saw some run that the verification failed

$ docker run gcr.io/projectsigstore/cosign:v2.1.0 verify --certificate-oidc-issuer=https://accounts.google.com --certificate-identity=keyless@distroless.iam.gserviceaccount.com gcr.io/distroless/static-debian11                                                                                                                                                                                                                                                                                           WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested                                                                                                                                                                                                                                                                                                                                                   Error: no matching signatures: nil certificate provided
main.go:69: error during command execution: no matching signatures: nil certificate provided

and eventually, that works if you increase the workers to let's say 50 that worked. this is because we were aborting the full execution of the signatures if the request jobs were bigger than the workers, now we wait for the workers be available to continue the process.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3084 (3da2c65) into main (412a096) will decrease coverage by 0.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   30.63%   30.11%   -0.52%     
==========================================
  Files         155      155              
  Lines        9793     9791       -2     
==========================================
- Hits         3000     2949      -51     
- Misses       6343     6411      +68     
+ Partials      450      431      -19     
Impacted Files Coverage Δ
pkg/cosign/verify.go 35.43% <0.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

@cpanato cpanato merged commit d3cd566 into sigstore:main Jun 26, 2023
26 checks passed
@cpanato cpanato deleted the fix branch June 26, 2023 12:23
@github-actions github-actions bot added this to the v2.1.1 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants