-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support attaching a Rekor bundle to a container #3246
Changes from 2 commits
894f96f
922292f
010b57c
57a60ed
b416628
e9425b0
b7c8838
58f2c6c
0190371
2e117d9
4544b8f
5bdd957
e155e42
4d776f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ type AttachSignatureOptions struct { | |
Cert string | ||
CertChain string | ||
TimeStampedSig string | ||
RekorBundle string | ||
Registry RegistryOptions | ||
} | ||
|
||
|
@@ -57,6 +58,8 @@ func (o *AttachSignatureOptions) AddFlags(cmd *cobra.Command) { | |
"signing certificate and end with the root certificate. Included in the OCI Signature") | ||
cmd.Flags().StringVar(&o.TimeStampedSig, "tsr", "", | ||
"path to the Time Stamped Signature Response from RFC3161 compliant TSA") | ||
cmd.Flags().StringVar(&o.RekorBundle, "rekor", "", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we name the flag There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, what is the sigstore bundle 👀 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_bundle.proto - sigstore-go and other newer clients use this rather than have separate outputs for cert, sig, rekor, etc |
||
"path to the rekor bundle") | ||
} | ||
|
||
// AttachSBOMOptions is the top level wrapper for the attach sbom command. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase variable, so
tsBundle