Set go to min 1.21 and update dependencies #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
+ Coverage 30.31% 30.32% +0.01%
==========================================
Files 155 155
Lines 9919 9921 +2
==========================================
+ Hits 3007 3009 +2
Misses 6462 6462
Partials 450 450
|
cpanato
force-pushed
the
updates
branch
3 times, most recently
from
049902f
to
539a90a
Compare
bobcallaway
previously approved these changes
Oct 28, 2023
bobcallaway
previously approved these changes
Oct 28, 2023
bobcallaway
previously approved these changes
Oct 28, 2023
| @@ -117,5 +117,5 @@ func (c *TSAClient) GetTimestampResponse(tsq []byte) ([]byte, error) { | |||
| tsStruct.Time = c.Time | |||
| } | |||
|
|
|||
| return tsStruct.CreateResponse(c.CertChain[0], c.Signer) | |||
| return tsStruct.CreateResponseWithOpts(c.CertChain[0], c.Signer, hashAlg) | |||
There was a problem hiding this comment.
These are different hash algs, this is for generating the hash for the signed timestamp structure. Let’s just hardcode to sha256
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
haydentherapper
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary