Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and clarify e2e scripts #3628

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Clean up and clarify e2e scripts #3628

merged 2 commits into from
Mar 29, 2024

Commits on Mar 28, 2024

  1. Add comment to test/piv_test.go 

    Since f6d8481 it's not clear what this file is for, as it's not run in
CI. Add a link to the docs that reference it to make it clear this is
still needed.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    772f99f View commit details
    Browse the repository at this point in the history

  2. Clean up unused test script 

    e2e_test_secrets.sh is no longer called from CI as of f633221. It's
objective is largely redundant with tests already in e2e_test.go, so
just remove it.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1ca4dea View commit details
    Browse the repository at this point in the history