pivkey: Change default slot to Signature (9c) #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default slot was Authentication (9a) which is intended to be used for authentication with SSH or similar systems. In the context of cosign, it makes more sense to default to the Signature slot which is intended for use with message and code signing. Signed-off-by: James Alseth <james@jalseth.me>
|
Thanks! We still don't have these tests running in CI so I'll pull in your branch and run them myself later today to make sure they don't break. |
dlorenc
approved these changes
Jul 18, 2021
|
Thanks! This Looks great. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default slot was Authentication (9a) which is intended to be used
for authentication with SSH or similar systems. In the context of cosign, it makes
more sense to default to the Signature slot which is intended for use with message
and code signing.
Signed-off-by: James Alseth james@jalseth.me