Add "cosign attest" command! #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
changed the title
|
TODO:
|
dlorenc
force-pushed
the
attest
branch
7 times, most recently
from
1fc0459
to
4b41a7c
Compare
dlorenc
changed the title
|
Dropping the WIP here, basic |
dlorenc
force-pushed
the
attest
branch
3 times, most recently
from
b2defbe
to
2d9b7a1
Compare
dekkagaijin
reviewed
Jul 22, 2021
cmd/cosign/cli/verify_attestation.go
Outdated
| flagset.StringVar(&cmd.Slot, "slot", "", "security key slot to use for generated key (default: signature) (authentication|signature|card-authentication|key-management)") | ||
| flagset.BoolVar(&cmd.CheckClaims, "check-claims", true, "whether to check the claims found") | ||
| flagset.StringVar(&cmd.Output, "output", "json", "output the signing image information. Default JSON.") | ||
| flagset.StringVar(&cmd.FulcioServer, "fulcio-server", "https://fulcio.sigstore.dev", "[EXPERIMENTAL] address of sigstore PKI server") |
There was a problem hiding this comment.
Suggested change
| flagset.StringVar(&cmd.FulcioServer, "fulcio-server", "https://fulcio.sigstore.dev", "[EXPERIMENTAL] address of sigstore PKI server") | |
| flagset.StringVar(&cmd.FulcioURL, "fulcio-url", "https://fulcio.sigstore.dev", "[EXPERIMENTAL] address of sigstore PKI server") |
cmd/cosign/cli/attest.go
Outdated
Comment on lines
125
to
128
| remoteOpts := []remote.Option{ | ||
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | ||
| remote.WithContext(ctx), | ||
| } |
There was a problem hiding this comment.
Suggested change
| remoteOpts := []remote.Option{ | |
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | |
| remote.WithContext(ctx), | |
| } | |
| remoteOpts := DefaultRegistryClientOpts(ctx) |
cmd/cosign/cli/verify_attestation.go
Outdated
Comment on lines
111
to
114
| RegistryClientOpts: []remote.Option{ | ||
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | ||
| remote.WithContext(ctx), | ||
| }, |
There was a problem hiding this comment.
Suggested change
| RegistryClientOpts: []remote.Option{ | |
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | |
| remote.WithContext(ctx), | |
| }, | |
| RegistryClientOpts: DefaultRegistryClientOpts(ctx), |
dekkagaijin
approved these changes
Jul 22, 2021
Signed-off-by: Dan Lorenc <dlorenc@google.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Lorenc dlorenc@google.com