Fix verify and verify-attestation output flag #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things on this PR.
1 - improve documentation, listing the possible options for
-output
-> '(json|text)'2 - fix existing behavior, where
-output
is actually ignored, using alwaystext
, even though the documentation says the default isjson
.A couple questions:
1 - I think it makes more sense to rename this flag to
-format
, instead of-output
considering the options (json/text).2 - The current default is
text
, but fixing this to follow the documentation, it becomesjson
, but I think text looks better on the command line.wdyt?