Drop the unused apiReader
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found another field that's unused, so I'm going to post an update in a sec. |
I noticed the unused parameter in my previous change and tugged. Seems completely unused. I also noticed another unused field for the unstructured decoder, so dropping that. Signed-off-by: Matt Moore <mattomata@gmail.com>
mattmoor
force-pushed
the
drop-reader
branch
from
36150e6
to
645547b
Compare
dlorenc
approved these changes
Sep 7, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the unused parameter in my previous change and tugged. Seems completely unused.
Signed-off-by: Matt Moore mattomata@gmail.com
/assign @dlorenc