Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for keyless verification #159

Closed
wants to merge 1 commit into from

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Apr 26, 2023

In the current documentation, the "Keyless verification" example misses the required parameters for cosign verify per sigstore/cosign#2411.

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 3b4c6a8
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/645108b58b2a9c00086c28a1
😎 Deploy Preview https://deploy-preview-159--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dmitris dmitris marked this pull request as ready for review April 26, 2023 16:35
@haydentherapper
Copy link
Contributor

Note that #156 should resolve this.

@haydentherapper
Copy link
Contributor

@dmitris Is it alright if I close this, given #156 should resolve this?

Signed-off-by: Dmitry S <dsavints@gmail.com>
@dmitris
Copy link
Contributor Author

dmitris commented May 2, 2023

@dmitris Is it alright if I close this, given #156 should resolve this?

It seems that it will take some time to merge #156 (big change, there are Changes Requested etc.) - and this one is very small but would help to avoid the confusion about the outdated and no longer needed COSIGN_EXPERIMENTAL flag and the required parameters for the keyless cosign verify. Unless we are sure to merge #156 in the next few days, I'd suggest to merge this one for now - but do whatever you think is best / makes more sense.

@haydentherapper
Copy link
Contributor

The PR should be good to go, so I'll close this one out. Otherwise this change would just get removed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants