Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved __redirects so it appears in public build #234

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

smythp
Copy link
Collaborator

@smythp smythp commented Aug 23, 2023

Summary

The redirect file wasn't appearing in the public build. In Hugo, the file needs to be included in the content folder to appear in the root public directory.

Notes

Creating this as a draft PR since I'd like to test the redirects using the Netlify build preview. I'll switch the PR status when it's ready to merge.

Resolves #230

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 0b96c81
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/64e6764a31de780007a64379
😎 Deploy Preview https://deploy-preview-234--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Deleted hugo-provided redirects layout

Added previous redirects to static (i.e., use a static redirects file
rather than a template)

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
@smythp smythp marked this pull request as ready for review August 23, 2023 21:26
@smythp
Copy link
Collaborator Author

smythp commented Aug 23, 2023

OK, Hugo already had a template for redirects taht was conflicting. Deleted the template and moved the _redirects file to static. Tested and redirects work in the preview build, so we're good to merge here.

@ltagliaferri ltagliaferri merged commit 7154528 into sigstore:main Aug 24, 2023
5 checks passed
@smythp smythp deleted the wrong-redirects-location branch August 24, 2023 22:24
normal-coder added a commit to normal-coder/Sigstore-Docs that referenced this pull request Aug 25, 2023
* main:
  ci(github action): add Markdown linter check support for main branch (sigstore#227)
  Redirects now appears in public (sigstore#234)
  add 'cosign sign-blob'in the mTLS TSA section (sigstore#239)
  Changed 404 text, restored i18n (sigstore#238)
  Restored Netlify redirects file (sigstore#233)
  Removed docs from URL path (sigstore#232)
  Corrected the confusion of steps in the document due to formatting (sigstore#220)
  Added anchor text to link to releases page (sigstore#223)
normal-coder added a commit to normal-coder/Sigstore-Docs that referenced this pull request Aug 25, 2023
* main:
  ci(github action): add Markdown linter check support for main branch (sigstore#227)
  Redirects now appears in public (sigstore#234)
  add 'cosign sign-blob'in the mTLS TSA section (sigstore#239)
  Changed 404 text, restored i18n (sigstore#238)
  Restored Netlify redirects file (sigstore#233)
  Removed docs from URL path (sigstore#232)
  Corrected the confusion of steps in the document due to formatting (sigstore#220)
  Added anchor text to link to releases page (sigstore#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back redirects
2 participants