Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues in header #278

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

smythp
Copy link
Collaborator

@smythp smythp commented Nov 24, 2023

Overview

This PR resolves two issues. First, the Sigstore logo was not properly nested with a link to the home page, creating an issue for screen readers (the link and the logo were registering as separate elements next to each other rather than one element). Second, the social buttons were improperly labeled, probably due to the anchor text being hidden in CSS.

Resolution

  1. The Sigstore logo has been placed inside the link to the home page. This shouldn't change the behavior for those not using a screen reader but should be better for screen reader users.
  2. An aria-label has been included in the Hugo logic for the header that generates the social buttons.
  3. I renamed the label for the dark mode toggle. Previously, it said "toggle user interface mode," which could mean anything. Now it says "toggle dark/light mode."

Notes

Resolves #275
Resolves #277

Resolves sigstore#275

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
Resolves sigstore#277

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 64a3eb6
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/6560dab010faaa000868762f
😎 Deploy Preview https://deploy-preview-278--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ltagliaferri ltagliaferri merged commit 9e75cd1 into sigstore:main Nov 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants