Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for new entry Pub/Sub #293

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jalseth
Copy link
Contributor

@jalseth jalseth commented Feb 19, 2024

Summary

Add docs for the Rekor Pub/Sub feature which will be live soon. Code change in sigstore/rekor#1580.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 43c60fb
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/65d3bd551a0b210008d47223
😎 Deploy Preview https://deploy-preview-293--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sigstore users can subscribe to events about new entries added to the
transparency log.

Signed-off-by: James Alseth <james@jalseth.me>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks


## Event format

The events are published in both the [JSON](https://github.com/cloudevents/spec/blob/main/cloudevents/formats/json-format.md) and [Protobuf](https://github.com/cloudevents/spec/blob/main/cloudevents/formats/protobuf-format.md) formats of the CloudEvents specificaion. The `data` field is always a serialized [`TransparencyLogEntry`](https://github.com/sigstore/protobuf-specs/blob/b46b842040854ceab8f3a42547ae6e991793d0ef/protos/sigstore_rekor.proto#L92) proto message. For JSON formatted events, this follows the JSON serialization [specification](https://protobuf.dev/programming-guides/proto3/#json) for Protobufs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only publishing in json currently. I can switch to both if you think we will see adoption of both formats, but I thought json would be more widely used.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bobcallaway bobcallaway merged commit f70968d into sigstore:main Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants