Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a payload to be provided with a signature #84

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Mar 10, 2023

Summary

This is the companion to sigstore/cosign#2785 ; I guess it should be discussed there.

Release Note

NONE

Documentation

Uh, this?

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit c41cc56
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/640bbd43ad350f00084879e0
😎 Deploy Preview https://deploy-preview-84--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ltagliaferri ltagliaferri merged commit 9af20fb into sigstore:main Mar 11, 2023
@mtrmac mtrmac deleted the require-payload branch March 13, 2023 15:43
@mtrmac
Copy link
Contributor Author

mtrmac commented Mar 13, 2023

(FWIW the Cosign PR for which this documentation update is necessary for has not been merged yet.)

@haydentherapper
Copy link
Contributor

Can we revert this, given I think there's going to be a lot of discussion in the other thread?

haydentherapper added a commit to haydentherapper/docs that referenced this pull request Mar 13, 2023
haydentherapper added a commit to haydentherapper/docs that referenced this pull request Mar 13, 2023
This reverts commit 9af20fb.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
ltagliaferri added a commit that referenced this pull request Mar 13, 2023
ltagliaferri pushed a commit that referenced this pull request Mar 13, 2023
This reverts commit 9af20fb.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants