Small ca refactor
#569
Merged
Small ca refactor
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 43.13% 44.56% +1.42%
==========================================
Files 20 21 +1
Lines 1472 1528 +56
==========================================
+ Hits 635 681 +46
- Misses 766 773 +7
- Partials 71 74 +3
Continue to review full report at Codecov.
|
added 2 commits
May 11, 2022 16:34
Moves each struct and interface into its own file Signed-off-by: Nathan Smith <nathan@chainguard.dev>
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
|
No concerns with this, but just wondering, what's the motivation for splitting it up? |
|
I just find it a little easier to read that way, but I'm ok either way. Adding the tests is more important bit here for me |
haydentherapper
approved these changes
May 12, 2022
|
I don't mind either way, no strong preference between multiple files and one, especially since this isn't too much code anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slit up the the structs / interfaces in
pkg/cainto seperate files and add tests for serialization / deserialization methods onCodeSigningCertificateRelease Note