Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests that require network access with HERMETIC=true #587

Merged
merged 2 commits into from
May 17, 2022
Merged

Skip tests that require network access with HERMETIC=true #587

merged 2 commits into from
May 17, 2022

Commits on May 16, 2022

  1. Skip tests that require network access with HERMETIC=true 

    The config tests make outbound network calls since Load() calls
prepare() which fetches the OIDC configs. Tests that call Load() will
now be skipped. Tested with `HERMETIC=true go test ./...` without a
network connection.

I didn't use go:build !hermetic beacuse this causes the build to skip
building the config package entirely.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    42c59e7 View commit details
    Browse the repository at this point in the history

  2. Switch to tag based 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed May 16, 2022
    Configuration menu
    Copy the full SHA
    48d0de4 View commit details
    Browse the repository at this point in the history