Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe all log messages to stdout for dev logger #673

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented Jul 6, 2022

Confirmed with docker logs -f fulcio-server 2>/dev/null

This only fixes the development logger, not the prod one.

Fixes #641

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #673 (92b71b6) into main (ee8e8f9) will decrease coverage by 7.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   62.02%   54.44%   -7.59%     
==========================================
  Files          30       36       +6     
  Lines        1717     2228     +511     
==========================================
+ Hits         1065     1213     +148     
- Misses        569      923     +354     
- Partials       83       92       +9     
Impacted Files Coverage Δ
cmd/app/http.go 53.96% <100.00%> (ø)
pkg/ca/fileca/load.go 58.62% <0.00%> (-10.35%) ⬇️
cmd/app/serve.go 19.33% <0.00%> (ø)
cmd/app/root.go 44.44% <0.00%> (ø)
cmd/app/createca.go 19.49% <0.00%> (ø)
cmd/app/version.go 31.81% <0.00%> (ø)
cmd/app/grpc.go 48.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9480e...92b71b6. Read the comment docs.

@cpanato cpanato merged commit f8a49b6 into sigstore:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All log messages have an error severity
4 participants