-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest file format #224
Labels
enhancement
New feature or request
Milestone
Comments
I'm going to prepare a manifest PR. That's based upon PR193 and adds a last modified field to the |
I'm currently working on one, to handle internal BCID needs. |
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this issue
Jul 24, 2024
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this issue
Jul 24, 2024
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this issue
Jul 24, 2024
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
added a commit
to mihaimaruseac/model-transparency
that referenced
this issue
Jul 24, 2024
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I wanted to reignite the discussion around a manifest file format. So, I tried to define two potential solutions as shown below.
The first part shows a simple solution to support a Merkle tree root hash and the per file hash approaches in an either / or fashion.
Here, we could also extend the
root_hash
field to a custom type if not all necessary information can be captured in the metadata section.The second part shows a solution that would support a mixed approach. I'm not sure it is necessary but just wanted to highlight it.
In both cases
metadata
is a simpledict[str, str]
type that allows users to add arbitrary metadata to the Manifest. This could also be extended to support a strongly typed key, value solution if necessary.The Manifest could be packaged in a DSSE envelope to follow their standard procedure for signing or (if sigstore is going to allow arbitrary data) we add a signature field to the Manifest file. I'd prefer going with the DSSE envelope since it's already well defined for this use case.
WDYT?
The text was updated successfully, but these errors were encountered: