Implement Sigstore signing and verification of models #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
previously approved these changes
Aug 5, 2024
The `ShardedFileManifestItem` objects (items in `ShardLevelManifest`) are recorded as a single string in the in-toto payloads used for signing. The canonicalization to string is done by appending the file (relative) path, the start offset and the end offset, separated by `:`. When validating a signature and rebuilding a manifest, we need to parse a string back to a shard. Rather than replicating this in all places, we create a member function for the conversion. Also adds the relevant tests. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Although names in in-toto are optional, for sigstore-python they are mandatory. So, we set the name to "." when we don't have other option. Updated goldens to reflect the change. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Supports both signing models serialized to digests (a la `serialize_v0`/`serialize_v1`) and models serialized to manifests. Suppoorts both signing digests directly and signing in-toto manifest. There is a need to convert from in-toto's in-toto types to the ones expected by sigstore-python, but this additional step will be removed in the future. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
force-pushed
the
sigstore-sign
branch
from
cfd9a96
to
186ed4c
Compare
laurentsimon
approved these changes
Aug 5, 2024
This was referenced Aug 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supports all payloads, although in the future we will deprecate most of them, as these are created to migrate existing
serialize_v0/serialize_v1implementation and to experiment with UX and benchmarking.Each commit can be reviewed individually. In order these are:
from_strmethod tomanifest.Shard: Adds a method toShardclass to ease parsing a signature back to manifest. Adds tests.sigstore-python. So, we use a default name of"."when another cannot be provided.SigstoreSignaturefor storing Sigstore signatures: as it says on the tin, just one simple class to allow saving and loading of SigstoreBundles.TODO: add tests for signing and verification, in a subsequent PR.
Release Note
NONE
Documentation
NONE