-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky sigstore tests on Windows #297
Fix flaky sigstore tests on Windows #297
Conversation
Five attempts of CI all passed, so I think this is good to go |
Should we look into running unit tests without networking? I took a look at what sigstore-python does, and played around with the following (I was unable to get it to work with unshare --map-root-user --net pytest -v . before:
Testing on this PR everything passes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% familiar with unittest.mock
but the CI seems stable and my unshare
experiment looked good 👍
Running with networking disabled was a good way to test that we completely mocked out Sigstore, this is a good suggestion -- thank you. Might be too late for this now, but we can try if we detect other flakyness / need to mock other services? |
Summary
It seems that I failed to properly mock Sigstore in testing and that was causing some flakiness on Windows. This should be fixed now.
I'm running each CI 5 times before sending this for review to make sure.
Release Note
NONE
Documentation
NONE