fix retrieve endpoint response code and add testing #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Fixes #1040
Fixes #1027
Adds some testing for #1041
This change improves response codes returned by erroneous entries on the
entries/retrieve
endpoint:Release Note
entries/retrieve
are changed: 404s are now returned for entries not found by hash, proposed entry, or index. 400s are returned for malformed entries. Previously, server returned 500.Documentation