update rekor intoto/0.0.2 entry hash calculation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <bdehamer@github.com>
|
/cc @codysoyland |
feelepxyz
reviewed
Nov 3, 2022
| // * payload is base64 encoded | ||
| // * signature is base64 encoded (only the first signature is used) | ||
| // * keyid is included ONLY if it is NOT an empty string | ||
| // * The resulting JSON is canonicalized and hashed to a hex string |
There was a problem hiding this comment.
Is it worth writing some kind of tests around this behaviour to make sure we don't deviate from it in future?
There was a problem hiding this comment.
Do we have some tests in src/tlog/verify.test.ts that create different kinds of envelopes with and without a keyid? Maybe with multiple sigs?
There was a problem hiding this comment.
@feelepxyz I added some more tests around the DSSE hash calculation to ensure that we don't unintentionally alter it.
feelepxyz
reviewed
Nov 3, 2022
Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/intoto-002-fixup
branch
from
78aa898
to
32ffd2d
Compare
feelepxyz
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian DeHamer bdehamer@github.com
Summary
Updates the logic to properly calculate the digest of a DSSE envelope when creating an intoto/0.0.2 style entry in Rekor.