Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'dsse' as the default rekor type when signing #631

Closed
wants to merge 1 commit into from

Conversation

bdehamer
Copy link
Collaborator

@bdehamer bdehamer commented Jul 21, 2023

Fixes #526
Replaces #552

Summary

Updates @sigstore/sign to use "dsse" as the default Rekor type when submitting DSSE-wrapped payloads. This replaces the current "intoto" type currently in use.

NOTE: Do not merge until the necessary support has been added to the rest of the stack accepting npm provenance statements.

Signed-off-by: Brian DeHamer <bdehamer@github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: b7bcdba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sigstore/sign Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@haydentherapper
Copy link

Hey! Just wanted to check if you know when this can be merged.

@bdehamer
Copy link
Collaborator Author

@haydentherapper I don't think we're quite ready to make the dsse Rekor type the default just yet -- this has implications for some of the older versions of npm which have versions of this library bundled (don't want to get in a position where older clients aren't able to verify newly signed packages). I'm not sure what the exact trigger will be, but when the usage numbers for some of those older npm versions start to dip we will consider switching the default.

That said, GH is about to deploy a new usage of this library where we will be using the dsse Rekor type exclusively.

@bdehamer
Copy link
Collaborator Author

bdehamer commented Oct 9, 2024

Closing in favor of #1270

@bdehamer bdehamer closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change default rekor type for attestations from 'intoto:0.0.2' to 'dsse'
2 participants