sign: Make SigningResult._to_bundle() public #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Sep 8, 2023
This enables signing applications to use the bundle format and seems in line with the other similar decisions: * The bundle is already part of the CLI interface * verify already contains similar public API (VerificationMaterials.from_bundle() is public) Closes sigstore#763 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Mention that changelog entry goes to CHANGELOG.md, not the PR description. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
make-to-bundle-method-public
branch
from
f5fc2c3 to
a953c5b
Compare
Done. Tweaked the PR template as well to make it clearer the release note goes to CHANGELOG.md. |
woodruffw
approved these changes
Sep 11, 2023
|
/gcbrun |
|
Thanks @jku! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables signing applications to use the bundle format and seems in line with the other similar decisions:
Closes #763
Release Note
sign.SigningResult.to_bundle()allows signing applications to serialize to the bundle format that is already usable in verification withverify.VerificationMaterials.from_bundle()Documentation