fix(types): incorrect return type of collectDefaultMetrics(), should be Timeout in Node #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Mind adding a |
|
Looks like |
|
Let's do dev dependencies so we don't pollute consumers' code with it. Ref jestjs/jest#8092 |
|
Can you please look into the broken ci? |
|
Updated dependencies, should be good now |
SimenB
reviewed
Jun 1, 2019
SimenB
reviewed
Jun 4, 2019
|
If you remove the unneeded package(-lock).json changes (now that we use the return type), we can merge this 🙂 |
|
I've changed as suggested, tests are good. Globals are strange, but I've tested in my project and it seems to work as it should. |
SimenB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.