Lazily add process event listener #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this. Initial 👍 , will review fully this weekend. |
|
I just realized that this actually broke cluster metrics. (My bad for not catching it.) I don't see a way to do what you're trying to do here without requiring users to call a setup function explicitly. Being explicit is probably best though. Working on a patch for v13 and v14 now.
Ugh, jest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attach a listener to
processwhen the cluster mode is used to prevent a memory leak after multiple requires.The tests are passing, but I'm not familiar with the way the cluster mode is working. So even if it seems ok to me according to the way it's used in
example/cluster.js, you might want to double check that I didn't break anything there 🙂Fixes #448.