Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openmetrics and exemplars support #544

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

karlodwyer
Copy link
Contributor

PR #482 hasn't been updated in a few months, so I thought @voltbit wouldn't mind if I finished this work up for him.

voltbit and others added 4 commits March 3, 2023 13:36
- Added support for OpenMetrics format, including exemplars
- Added support for exemplars with OpenTelemetry tracing data on
  default metrics
- Added the option of passing params as one object to observe() and inc()
methods
@karlodwyer karlodwyer marked this pull request as ready for review March 3, 2023 14:45
@SimenB
Copy link
Collaborator

SimenB commented Mar 3, 2023

Thanks! I'll take a proper look later, but could you target the next branch?

@karlodwyer
Copy link
Contributor Author

sure, I see a bunch of test failures that weren't happening locally, so let me rebase and investigate

@karlodwyer karlodwyer changed the base branch from master to next March 3, 2023 15:23
Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it

@SimenB SimenB changed the title [commandeer PR #482] Add openmetrics and exemplars support Add openmetrics and exemplars support Mar 6, 2023
@SimenB SimenB merged commit a16894a into siimon:next Mar 6, 2023
@SimenB SimenB mentioned this pull request Mar 6, 2023
5 tasks
SimenB pushed a commit that referenced this pull request Mar 6, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
@karlodwyer
Copy link
Contributor Author

Excellent, do you have a timeframe for the next release in mind @SimenB ?

@SimenB
Copy link
Collaborator

SimenB commented Mar 7, 2023

Need to apply #542 on next, then we should be good to go

SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
SimenB pushed a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
@zbjornson zbjornson mentioned this pull request Mar 11, 2023
@SimenB
Copy link
Collaborator

SimenB commented Oct 9, 2023

https://github.com/siimon/prom-client/releases/tag/v15.0.0

Finally - sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants