-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openmetrics and exemplars support #544
Conversation
- Added support for OpenMetrics format, including exemplars - Added support for exemplars with OpenTelemetry tracing data on default metrics - Added the option of passing params as one object to observe() and inc() methods
Thanks! I'll take a proper look later, but could you target the |
sure, I see a bunch of test failures that weren't happening locally, so let me rebase and investigate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do it
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Excellent, do you have a timeframe for the next release in mind @SimenB ? |
Need to apply #542 on |
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
Co-authored-by: Andrei Dobre <andreidobre.web@gmail.com>
https://github.com/siimon/prom-client/releases/tag/v15.0.0 Finally - sorry about the delay! |
PR #482 hasn't been updated in a few months, so I thought @voltbit wouldn't mind if I finished this work up for him.