feat: enhance error output on not valid name and label names #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working I was facing an error performing some testing because of no valid metric name and no valid label names.
I decided to dive into the code to get more output in the error.
The changes are the following:
Show the invalid name in the error.
Invalid metric name
Invalid metric name: ${this.name}
Show the invalid label names instead of a generic message
invalid
labels. So it returns an array instead of a booleanthrow new Error('Invalid label name');
Invalid metric name: ${this.name}
The changes have been tested by unit testing inside the gauge test case. It could be in any other metric that inherits from the metric abstract class.