pr comment adjustments

Signed-off-by: David Sinclair <david@sinclair.tech>

config/opensearch_dashboards.yml

@@ -1,8 +1,3 @@
-opensearch.hosts: ["https://localhost:9200"]
-opensearch.username: "admin" # Default username on the docker image
-opensearch.password: "admin" # Default password on the docker image
-opensearch.ssl.verificationMode: none
-
 # OpenSearch Dashboards is served by a back end server. This setting specifies the port to use.
 #server.port: 5601
 

package.json

@@ -11,7 +11,7 @@
     "dashboarding"
   ],
   "private": true,
-  "version": "2.3.0",
+  "version": "3.0.0",
   "branch": "main",
   "types": "./opensearch_dashboards.d.ts",
   "tsdocMetadata": "./build/tsdoc-metadata.json",

src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx

@@ -83,7 +83,11 @@ interface Props {
   SavedObjectFinder: React.ComponentType<any>;
   stateTransfer?: EmbeddableStateTransfer;
   hideHeader?: boolean;
-  isRetained?: boolean;
+  // By default, embeddable.destroy() is called when this component unmounts.
+  // To prevent this default behavior, set this prop to true.
+  isDestroyPrevented?: boolean;
+  // Toggle off the border and shadow applied around the embeddable.
+  // By default, the embeddable will have a shadow and border around it.
   isBorderless?: boolean;
 }
 
@@ -203,7 +207,7 @@ export class EmbeddablePanel extends React.Component<Props, State> {
       this.state.errorEmbeddable.destroy();
     }
 
-    if (!this.props.isRetained) {
+    if (!this.props.isDestroyPrevented) {
       this.props.embeddable.destroy();
     }
   }

src/plugins/ui_actions/public/types.ts

@@ -65,7 +65,7 @@ export interface TriggerContextMapping {
   [VISUALIZE_GEO_FIELD_TRIGGER]: VisualizeFieldContext;
 }
 
-export const DEFAULT_ACTION = '';
+const DEFAULT_ACTION = '';
 export const ACTION_VISUALIZE_FIELD = 'ACTION_VISUALIZE_FIELD';
 export const ACTION_VISUALIZE_GEO_FIELD = 'ACTION_VISUALIZE_GEO_FIELD';
 export const ACTION_VISUALIZE_LENS_FIELD = 'ACTION_VISUALIZE_LENS_FIELD';