Fix a bug when formatting consecutive -define directives with single-quoted macro names.
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-quoted macro names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Copilot Summary
This pull request includes changes to improve the handling of macro definitions in the
FormatStatestruct and updates to the corresponding test data. The most important changes include modifying the way macro name lengths are calculated and adding new test cases for macro definitions.Improvements to macro definition handling:
efmt_core/src/items/module.rs: Modified the calculation of macro name lengths to use the start and end positions of the macro name token. This ensures more accurate length calculation.Updates to test data:
tests/testdata/aligned_macro.erl: Added new test cases for macro definitions with different lengths and special characters to ensure the updated length calculation works correctly.