Use the parent dir of target files as the dir for temp files #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$ efmt --write /path/to/file.erlis executed, the currentmasterbranch create a temporary file in the system temp dir (e.g.,/tmp/) to write the formatted result. Then, it renames the temp file with the input file (/path/to/file.erlin this case).A problem is that there is not guarantee that both the input and temp files are located in the same filesystem. If it isn't, the rename operation would fail.
This PR changes the temp file dir to the parent dir of input files to fix this problem.