Reduce floating point errors in decoding #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Although floating point numbers may have errors, numbers which can be represented without errors should be treated without errors. This patch reduce floating point errors by avoiding the use of decimals.
In spite of that 123000000000000000000 > 253, 123000000000000000000 can be exactly represented in IEEE 754 format since it can be divided by 2 many times.
My concern is performance. Division may be slower than multiplication.
My coworker wrote this patch and he has agreed to post it here.