Merge pull request #30 from Shnatsel/fix-unsound-prefix

Drop unsafe code from currently unsound function prefix()
sile · May 27, 2019 · 4c9de73 · 4c9de73
2 parents 14c7627 + 55c89a9
commit 4c9de73
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/lz77/default.rs b/src/lz77/default.rs
@@ -109,14 +109,9 @@ impl Lz77Encode for DefaultLz77Encoder {
 }
 
 #[inline]
-fn prefix(buf: &[u8]) -> [u8; 3] {
-    unsafe {
-        [
-            *buf.get_unchecked(0),
-            *buf.get_unchecked(1),
-            *buf.get_unchecked(2),
-        ]
-    }
+fn prefix(input_buf: &[u8]) -> [u8; 3] {
+    let buf: &[u8] = &input_buf[..3]; // perform bounds check once
+    [buf[0], buf[1], buf[2]]
 }
 
 #[inline]