Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating client-related sub-entities should return ids and not bool. #33

Conversation

Fildrance
Copy link

Having non 200 status will throw exception from insides of Flurl, no need to return this stuff, but ids are needed for others related methods (for creating permissions for example).
Also corrected bug that creation of group policy was not getting sub-route properly applied.

@sps-campbellwray sps-campbellwray merged commit 275075b into silentpartnersoftware:main Mar 27, 2024
@Fildrance
Copy link
Author

Fildrance commented Mar 27, 2024

and new release pls :<

@Fildrance Fildrance deleted the feature/fix-return-values-of-auth-scopes-and-resources branch March 27, 2024 21:17
@sps-campbellwray
Copy link

@Fildrance
Copy link
Author

ty ty!

@Fildrance
Copy link
Author

image
most likely old version of source code (before this merge) was used to create v1.0.24 package

@sps-campbellwray
Copy link

That is exactly what happened...

I have unlisted 1.0.24 for the time being until I work out how to fix this, unfortunately NuGet package versions are immutable by the look of things, so it'll like be a new version number.

@sps-campbellwray
Copy link

The package is now released as 1.0.25, and I have updated the GitHub release accordingly. Apologies for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants