Upgrade libs kc17 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded to net-6.0 Upgraded Flur Library Removed compatibility for .net classic Removed compatibility for .net standard 1.x
|
@AnderssonPeter Any feedback, can you get this merged? |
|
Sorry for the late reply, I must have missed the email notifying me of this pull request. Did Flurl.Http have a breaking change that is causing all the ResponseMessage changes? Also there seems to be a lot of conflicts, could you fix those? |
|
Thanks for getting back to me.
I'll merge your changes, and republish. No issue.
Fluro has breaking charges, yes
…On Thu, Jan 5, 2023, 12:42 Peter ***@***.***> wrote:
Sorry for the late reply, I must have missed the email notifying me of
this pull request.
Did Flurl.Http have a breaking change that is causing all the
ResponseMessage changes?
Also there seems to be a lot of conflicts, could you fix those?
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALDFJVLXCC3PUQSX7EOIV3WQ2QPRANCNFSM6AAAAAATOWXIOQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@psavva any news? |
|
I'm out of the country and will return late January.
I'll resubmit the PR on my return.
Looking forward to helping support this library.
Best Regards
Panayiotis Savva
…On Thu, Jan 12, 2023, 19:01 Peter ***@***.***> wrote:
@psavva <https://github.com/psavva> any news?
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALDFJVKDBOX6HYHWSZL6WDWSA2H7ANCNFSM6AAAAAATOWXIOQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closed
|
closing this PR and will open a new one with changes needed for the upgrade in separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.