Improve callable check to allow PHP 8 compatibility #259
Conversation
|
@iansltx links to rfc that changed the behavior? what is the error you are fixing? include such details to PR body! also, if PR is not ready (CI fails right now, for example), convert it to Draft: |
|
@glensc Two tests fail due to throwing a TypeError when attempting to define, or protect, the integer 123, contained in the "bad services" data provider in the tests. The tweaks I added short-circuit prior to making the method_exists call that would cause the TypeError, ensuring that error condition throws the same exception that it did before PHP 8. You can see the issue for yourself if you pull down master and run the test suite locally on PHP 8.0. As for the build failure, Travis doesn't yet have a PHP 8.0 environment apparently. Let's see if nightly works... |
composer.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.2.5", | |||
| "php": "^7.2.5 || ^8", | |||
There was a problem hiding this comment.
Can you use >=7.2.5 instead? That's what we decided to use on my other projects.
|
@fabpot In case the earlier comment didn't notify, I revised the PR to use the >= PHP version constraint as requested. |
|
Thank you @iansltx. |
|
CHANGELOG not updated for 3.3.1 release |
|
@glensc Fixed |
No description provided.