Release 3.10.16 - allow underscores in tag names #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use silintl/mariadb, we use mariadb images directly.
We use mariadb directly now.
…mariadb Feature/remove silintl mariadb
Allow underscores in repository names.
mtompset
reviewed
Jan 4, 2024
| run parseImageName | ||
| [ ! -z $status ] | ||
| [ "$output" == "something:tag_123" ] | ||
| echo "output = $output" 1>&2 |
There was a problem hiding this comment.
These three lines of code are arcane shell scripting.
There was a problem hiding this comment.
Should I care? Do you have a suggestion?
There was a problem hiding this comment.
For those reading this after the fact, @mtompset and I discussed this directly. We determined that since this is using a test framework (bats) that may affect how this is implemented, the arcane scripting can be left as it is.
mtompset
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Fixed
Release PR Checklist
ecs-deployscriptRelease _._._ - Summary of change(using whateverthe new version number is, plus a succinct summary of what changed)