Leverage struct copy by value in clone

silphid · May 17, 2021 · efccd7e · efccd7e
1 parent cd9f9cb
commit efccd7e
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/internal/ctx/ctx.go b/src/internal/ctx/ctx.go
@@ -43,16 +43,12 @@ func Load(file string) (Context, error) {
 
 // Clone returns a deep-copy of this context
 func (c Context) Clone() Context {
-	clone := Context{
-		Container: c.Container,
-		Name:      c.Name,
-		Image:     c.Image,
-		Env:       make(map[string]string),
-		Mounts:    make(map[string]string),
-	}
+	clone := c
+	clone.Env = make(map[string]string)
 	for key, value := range c.Env {
 		clone.Env[key] = value
 	}
+	clone.Mounts = make(map[string]string)
 	for key, value := range c.Mounts {
 		clone.Mounts[key] = value
 	}