-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "network" model option with "host" default value. #22
Conversation
Add "hostenv" option to pass host env vars as is.
src/internal/context.go
Outdated
@@ -17,9 +17,11 @@ type Context struct { | |||
Image string | |||
Build DockerBuild | |||
Env map[string]string | |||
HostEnv []string `yaml:"hostenv,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment meant for line 15: shouldn't it be yaml:"-"
since the context name is not in the yaml file but built by us? Doesn't matter though but odd.
src/internal/context.go
Outdated
if source.Network != "" { | ||
merged.Network = source.Network | ||
} | ||
merged.HostEnv = append(merged.HostEnv, source.HostEnv...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dedup?
Je sais qu'on avait discuté de supporter:
mais, à court terme, j'ai plutôt opté pour la solution la plus simple et proche de la commande CLI
On pourra plus tard ajouter le support pour l'extrapolation de variables avec |
Your suggesting the the empty string gets mapped to the host env? I think we might as well just do the feature correctly. we basically only need to figure out one regex |
Add "hostenv" option to pass host env vars as is.