Add --dry-run and --verbose flags #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmdm
reviewed
Jun 23, 2021
| if options.Reset { | ||
| if options.Verbose { | ||
| fmt.Fprintf(os.Stderr, "removing container first") | ||
| } | ||
| if err := docker.Remove(ctx, containerName); err != nil { |
There was a problem hiding this comment.
i just realized there is a bug here. What if we run with reset but the container doesn't exist? We don't want to fail. Not to do with the PR but just thought I would flag it. I probably wrote the bug.
davidmdm
reviewed
Jun 23, 2021
| if err := docker.Remove(ctx, containerName); err != nil { | ||
| return fmt.Errorf("failed to remove container %q: %w", containerName, err) | ||
| } | ||
| } | ||
|
|
||
| var runOptions []docker.RunOption |
There was a problem hiding this comment.
we can probably do away with creating an options slice since all options accept their values. we can pass the empty string to WithWorkDir because even if we dont't pass the option it probably initialises the backing option to empty string anyways.
davidmdm
reviewed
Jun 23, 2021
| if options.Verbose { | ||
| fmt.Fprintln(os.Stderr) | ||
| } | ||
| if !options.DryRun { |
There was a problem hiding this comment.
Dry-run does not print the banner but still starts the docker process? Wouldn't the flag be --no-banner?
davidmdm
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.