contextfile loading wip #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silphid
approved these changes
May 19, 2021
| } | ||
|
|
||
| // parseContextFile unmarshals the contextFile data and resolves any parent contextfiles | ||
| func parseContextFile(data []byte) (*Contexts, error) { |
There was a problem hiding this comment.
Pourquoi *Contexts plutôt que simplement Contexts? Je préfère n'utiliser les pointeurs que lorsque c'est utile ou nécessaire.
|
|
||
| if errors.Is(err, os.ErrNotExist) { | ||
| if wd == "/" { | ||
| return nil, fmt.Errorf("failed to find a .yeyrc in directory hierarchy") |
There was a problem hiding this comment.
Faut juste garder en tête que, présentement, si l'utilisateur ne travaille pas dans un sous-répertoire de son HOME, on ne regardera jamais pour un fichier ~/.yeyrc.yaml. Faudrait éventuellement rajouter que si on atteint le root ici, on regarde directement à ~/.yeyrc.yaml (au pire, on va déjà avoir regardé là si on était parti d'un sous-répertoire de HOME, mais au moins on le manquera pas dans le cas inverse).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.