code review discussions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silphid
approved these changes
May 27, 2021
| output, err := cmd.Output() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return getOutputLines(output), nil | ||
| return strings.Split(string(output), "\n"), nil |
There was a problem hiding this comment.
Sur Windows, les séparateurs de lignes sont "\r\n", si on veut être multi-plateforme... C'est pour ça que j'avais fait getOutputLines()
src/internal/docker/cli.go
Outdated
| } | ||
|
|
||
| func startContainer(ctx context.Context, containerName string, cmd []string) error { | ||
| args := append([]string{"start", "-i", containerName}, cmd...) |
There was a problem hiding this comment.
docker start does not accept command name/args at the end, I fixed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of the docker cli branch, pointing back into the docker cli branch.
Restructure docker CLI file and have working commands.
But lots of stuff to discuss!!!!!!!!