[Do Not Merge] Begin standing up Inner Core #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
force-pushed
the
xxx-inner-core
branch
from
5b4e29c to
f18f395
Compare
CodaFi
reviewed
Mar 26, 2018
| @@ -73,4 +73,26 @@ final class Scope { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public static func == (lhs: Scope, rhs: Scope) -> Bool { | |||
| return ObjectIdentifier(lhs) == ObjectIdentifier(rhs) | |||
There was a problem hiding this comment.
You can delegate the equality test to the entry continuation instead of going through ObjectIdentifier. That should always be unique (an invariant for the verifier as well, I suppose).
harlanhaskins
force-pushed
the
xxx-inner-core
branch
from
d558ac8 to
bf6405d
Compare
CodaFi
reviewed
Apr 5, 2018
Sources/OuterCore/GIRWriter.swift
Outdated
| for cont in self.continuations { | ||
| guard visited.insert(cont).inserted else { continue } | ||
| let scope = Scope(cont) | ||
| for scope in topLevelScopes { |
There was a problem hiding this comment.
I rely on the Set to form a whitelist now, sorry about that.
harlanhaskins
force-pushed
the
xxx-inner-core
branch
2 times, most recently
from
ce53a4e to
a16d968
Compare
harlanhaskins
force-pushed
the
xxx-inner-core
branch
from
a16d968 to
f2f07b2
Compare
CodaFi
approved these changes
Apr 17, 2018
harlanhaskins
force-pushed
the
xxx-inner-core
branch
from
f2f07b2 to
8ada89f
Compare
harlanhaskins
force-pushed
the
xxx-inner-core
branch
from
8ada89f to
50139c1
Compare
|
Build passed on Linux 🎉 (passes locally on macOS) ⛵ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Begins standing up the Inner Core and starts the process of prototyping a GraphIR mangler. This will be necessary as we emit LLVM IR.
Resolves: Issue #104
Why merge this pull request?
Don't, so far.
What's worth discussing about this pull request?
We need to flesh out the mangling scheme. What I have is woefully incomplete.
What downsides are there to merging this pull request?
Right now? A lot of them. It don't work.