This is inline all publicAll... commands. But I'm not sure why we don't support that for Partners tbh.
Maybe something to tackle together with the create- commands ticket?

Also the error when running silverfin update-<any-template-type> --all --partner <id> --message "Update all is not clear.

It is not saying it is not supported, it just says missing IDs.

I would vote for change it now, replace "firm" with type and support it for every update- command. What do you think?

In the index.js file, we seemed to use the type already in the underlying functions, so is it correct that I only needed to change the "firm" to settings.type (4 times -> Reconciliations, export files, account templates, shared parts).

Since we are supporting it, we won't have to adjust the error either, I assume?

I know I mentioned to remove the partner check, but later we decided to not support update-all and create-all on partners.

And I wonder if we should do that still in this PR, because if not we could still be releasing something not fully working?

keeping the fixed "firm" parameter is not going to prevent going through the entire process when you select partners -> it will fail because of the wrong id (the firm id is not the partner id)

But I think we should do the right thing now, and implement the block for Partners in update/create all in here.
So a way to check if the option is partner and the command is update or create, and the flag is set to all. We block the process, show an error message, and don't run any further methods.

What do you think

Sorry @BenjaminLangenakenSF , but I would prefer to have all this conditions on /bin/cli.js rather than index.js
I see this contrain related to the CLI commands & flags, so we add it there, while keeping the functionality 'clean'

If we ever support them, again we update CLI commands & flags.

What do you think?

Hi @AgustinSilverfin

How would that look like? Something like this?

So adding a condition to check on the combination of those options and then a process.exit?

Yes.
Or even cleaner (to avoid repeating always the same and adding multiple lines) we create a helper method like cliUtils.checkUniqueOption(["handle", "all"], options) or cliUtils.checkDefaultFirm(options.firm, firmIdDefault) where we pass options

E.g. cliUtils.checkPartnerSupport(options) I believe the condition is options.all and options.type == partner, right?

Thanks for the explanation Rufo, added a fixup commit 😉
Looks ok?