BA-1196: add contributing and code of conduct #59
Conversation
deboracosilveira
requested review from
Janekk,
pablogadhi,
anicioalexandre,
ficast and
dpTsl
|
CONTRIBUTING.md
Outdated
|
|
||
| 1. Check the [GitHub Issues](https://github.com/silverlogic/baseapp-frontend/issues) to ensure that the feature hasn't already been requested. | ||
|
|
||
| 2. If the feature hasn't been requested, create a new issue by clicking on the "New Issue" button. |
There was a problem hiding this comment.
let's make sure people use the right label too, maybe for features requests we could use the enhancement label
CONTRIBUTING.md
Outdated
| 3. Create a new branch for your feature or bug fix: | ||
|
|
||
| ``` | ||
| git checkout -b feature-name |
There was a problem hiding this comment.
if it's not tied to any jira ID we could use BA-feature-name
CONTRIBUTING.md
Outdated
| 5. Commit your changes with a clear and concise commit message: | ||
|
|
||
| ``` | ||
| git commit -m "Add feature: Your feature description" |
There was a problem hiding this comment.
same here, if not tied to any id we could use "BA: feature description"
|
|
||
| 7. Open a Pull Request (PR) against the `master` branch of the BaseApp repository. | ||
|
|
||
| 8. Provide a descriptive PR title and include details about the changes you've made. |
There was a problem hiding this comment.
maybe we could add another step to make sure people read the versioning section on the readme
CONTRIBUTING.md
Outdated
|
|
||
| 1. Check the [GitHub Issues](https://github.com/silverlogic/baseapp-frontend/issues) to ensure that the bug hasn't already been reported. | ||
|
|
||
| 2. If the issue hasn't been reported, create a new issue by clicking on the "New Issue" button. |
There was a problem hiding this comment.
let's make sure people use the right label too, maybe for bugs requests we could use the bug label
deboracosilveira
force-pushed
the
BA-1196-contributing-guidelines
branch
from
ec908df
to
af8363f
Compare
deboracosilveira
force-pushed
the
BA-1196-contributing-guidelines
branch
from
6535705
to
311040d
Compare
Add contributing and code of conduct